Skip to content

fix: scroll to the bottom after the state update #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: scroll to the bottom after the state update #1928

merged 2 commits into from
Mar 7, 2023

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 3, 2023 •
edited
Loading

Motivation

An alternative version of #1889. This PR also fixes #1724.

Scroll to the bottom fix:

1736.mp4

Update widget content and scroll position after the widget shows:

1724.mp4

Change description

Scroll to the bottom of the monitor widget after the state update.

Other information

Closes #1724
Closes #1736

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: scroll to the bottom after the state update
ff1ddea 
Closes #1736

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this pull request Mar 3, 2023
Closed
4 tasks
fix: update monitor output after widget show
656357d 
Closes #1724

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos self-assigned this Mar 3, 2023
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Mar 3, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 March 3, 2023 08:19
@kittaakos kittaakos marked this pull request as ready for review March 3, 2023 08:20
@sfe-SparkFro
Copy link

I tested the Windows_X86-64_zip, it does appear to fix both #1736 and #1724. Fine with me if this replaces #1889, thanks for doing this!

@arduino arduino deleted a comment from Cosmos-32 Mar 5, 2023
per1234
per1234 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1724 and #1736 and didn't discover any regressions.

Thanks Akos!

@kittaakos kittaakos merged commit 24dc0bb into main Mar 7, 2023
@kittaakos kittaakos deleted the #1736 branch March 7, 2023 15:11
@per1234 per1234 mentioned this pull request Apr 14, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels

topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Serial Monitor scroll is incomplete when autoscroll is enabled Serial Monitor does not Autoscroll on new content received when view is not in focus

3 participants

@kittaakos @sfe-SparkFro @per1234